Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enhance the safegard when deleting top queries records #213

Closed
ansjcy opened this issue Jan 24, 2025 · 1 comment
Closed

[FEATURE] Enhance the safegard when deleting top queries records #213

ansjcy opened this issue Jan 24, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@ansjcy
Copy link
Member

ansjcy commented Jan 24, 2025

Is your feature request related to a problem?

We rely on the isTopQueriesIndex function when deleting outdated query insights data. And that function only uses index name to decide if it is a query insights index. This is very dangerous and we could be deleting customer data. Think about use cases when:

  • Customers create an index that can matches the index pattern
  • We are adding more features in the exporter in the future and changed the isTopQueriesIndex matching and it somhow returns true for non query insights indices. We will be deleting customer data

What solution would you like?

Additional safegard should be added like, adding certain metadata to indicate "this is a query insights data".

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@ansjcy ansjcy added enhancement New feature or request untriaged labels Jan 24, 2025
@ansjcy ansjcy changed the title [FEATURE] Enhance the safe gard when deleting top queries records [FEATURE] Enhance the safegard when deleting top queries records Jan 24, 2025
@ansjcy
Copy link
Member Author

ansjcy commented Jan 28, 2025

This is fixed in #210

@ansjcy ansjcy closed this as completed Jan 28, 2025
@ansjcy ansjcy removed the untriaged label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant