Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skipping changelog #5088

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

kotwanikunal
Copy link
Member

Signed-off-by: Kunal Kotwani kkotwani@amazon.com

Description

  • Add support for skipping changelog verifier when labelled with skip-changelog

Issues Resolved

  • N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@kotwanikunal kotwanikunal requested review from a team and reta as code owners November 4, 2022 20:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member

andrross commented Nov 4, 2022

> Task :server:spotlessJava FAILED
Step 'Refuse wildcard imports' found problem in 'src/test/java/org/opensearch/ExceptionSerializationTests.java':
Do not use wildcard imports.  'spotlessApply' cannot resolve this issue.

@kotwanikunal Any idea what is going on with this failure?

@kotwanikunal
Copy link
Member Author

> Task :server:spotlessJava FAILED
Step 'Refuse wildcard imports' found problem in 'src/test/java/org/opensearch/ExceptionSerializationTests.java':
Do not use wildcard imports.  'spotlessApply' cannot resolve this issue.

@kotwanikunal Any idea what is going on with this failure?

No clue. I do not see any wildcard imports.
I tried running spotlessCheck but it succeeds without any issues.

kkotwani@3c22fbb2c92e OpenSearch % ./gradlew spotlessCheck

> Configure project :qa:os
Cannot add task 'destructiveDistroTest.docker' as a task with that name already exists.
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.5.1
  OS Info               : Mac OS X 10.16 (x86_64)
  JDK Version           : 11 (Oracle JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-11.0.5.jdk/Contents/Home
  Random Testing Seed   : 554A225CEEA175E7
  In FIPS 140 mode      : false
=======================================

BUILD SUCCESSFUL in 34s
169 actionable tasks: 154 executed, 15 up-to-date

Maybe an intermittent failure?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 3ffa46a into opensearch-project:main Nov 7, 2022
@dblock dblock added backport 1.x backport 2.x Backport to 2.x branch labels Nov 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2022
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 3ffa46a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2022
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 3ffa46a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Nov 8, 2022
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 3ffa46a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Nov 8, 2022
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 3ffa46a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross added the backport 2.4 Backport to 2.4 branch label Nov 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2022
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 3ffa46a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Nov 8, 2022
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 3ffa46a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kotwanikunal kotwanikunal deleted the skip-changelog branch March 14, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 2.x Backport to 2.x branch backport 2.4 Backport to 2.4 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants