Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenApi at version '1.0.0' on 1.x branch vs '1.0.1' for other gems #122

Closed
woidda opened this issue Nov 30, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@woidda
Copy link

woidda commented Nov 30, 2022

Not really a bug, but a tiny annoyance when you update your gems.

Should OpenSearch::API::VERSION not be '1.0.1' or don't you keep the different gems in sync for the published versions?

See:

.../1.x/opensearch-api/lib/opensearch/api/version.rb

vs

.../1.x/opensearch-transport/lib/opensearch/transport/version.rb

@woidda woidda added the bug Something isn't working label Nov 30, 2022
@dblock
Copy link
Member

dblock commented Nov 30, 2022

Related, we're trying to centralize API spec and publish OpenAPI in opensearch-project/opensearch-api-specification#34.

@nhtruong
Copy link
Collaborator

nhtruong commented Dec 7, 2022

Hi @woidda,
We're not syncing up the versions of these gems. The fact that the versions appeared in sync was a coincidence as we used to do releases for these gems at the same time. We're now able to do releases much more often, and we're planning to deploy a new version of each gem as soon as it's viable.

If you install the opensearch-ruby or opensearch-aws-sigv4 gem, the appropriate versions of api and transport gems will be installed as dependencies.

@woidda
Copy link
Author

woidda commented Dec 7, 2022

I use these two:

gem "opensearch-ruby", "~>1.0"
gem "opensearch-transport", "~>1.0"

So I can replace this by including only opensearch-ruby, correct?

OK this makes it easier. I was not sure about the semantics you use for versioning as the elasticsearch gems afaik used the same version numbers for fitting parts.

Thanks for your reply and your work. I am looking forward to when opensearch becomes more mainstream and the confusion around naming things and what libs are available in what programming language disappears...

@woidda woidda closed this as completed Dec 7, 2022
@nhtruong
Copy link
Collaborator

@woidda Thanks for the kind words and for understanding. And yes we have plans to improve these clients, esp in regard to Opensearch's unique features :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants