Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Link checker didn't detect the broken link for files in github repository #90

Closed
tlfeng opened this issue Oct 12, 2021 · 3 comments

Comments

@tlfeng
Copy link
Contributor

tlfeng commented Oct 12, 2021

I found some broken links in UPGRADING.md, they pointed to files in another github repository, whose locations have changed.

Seeing from the results of link checker runs, there is no error to show the broken links:
https://github.com/opensearch-project/opensearch-plugins/actions/workflows/links.yml

I could create PR to change the above broken links to github permalink.

@tlfeng tlfeng changed the title [BUG] Link checker doesn [BUG] Link checker didn't detect the broken link for files in github repository Oct 12, 2021
@AMoo-Miki
Copy link

I fixed the links in #100 but am wondering why the link-checker missed those bad links. I will try and figure it out.

@tlfeng
Copy link
Contributor Author

tlfeng commented Nov 9, 2021

I fixed the links in #100 but am wondering why the link-checker missed those bad links. I will try and figure it out.

Hi Miki, thank you for fixing the links. I noticed the broken links for files in Github repo return the status 200, but not 4xx, but I didn't investigate further.

@dblock
Copy link
Member

dblock commented Apr 18, 2022

I'll close this. Since the host returns 200s link checker doesn't think they are broken.

@dblock dblock closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants