-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish minimal distribution to maven #2068
Comments
[Triage] We will update more about this issue once this meta #1916 to publish zips to maven repo is taken care. |
FYI: it seems that someone (atlassian?) at some point already uploaded some tar fields of some releases (lots of "some" in this sentence 😆) to the atlassian maven repo: https://mvnrepository.com/artifact/org.opensearch.distribution once this is done properly centrally then those other usages can go away. |
I don't see why not, except that it would be duplicate authoritative content. But since we publish plugin zips, we might as well publish a min distribution the same way. |
I don't see any problem with this either. We already publish min artifacts on artifact.opensearch.org, so publishing it to maven does not seem like additional risk to me. It would rather help simplify building things for the community like plugin development |
see my comment on #2069 on the general usefulness of having this on maven. @bbarani: for the min artefacts: i see a big difference between a docker image (which you can just grab & run and don't think twice about) and an artefact on maven (generally only used by enterprise-y setups / people who hopefully know what they're doing). if you're grabbing something like this off of maven you have a pretty good idea of what you're doing and will be adding the necessary security plugin (OpenSearch Security, Search Guard FLX or whatever else might be on the market in the future) or explicitly don't add one if such a use-case would exist. |
@rursprung thanks for your inputs. @elfisher @CEHENKLE @dblock @setiah Please provide your inputs as well to proceed further. |
I am fine giving up pushing back on also publishing everything to maven - people (@rursprung really) are asking for it, so YOLO. |
It makes my palms sweat, because I don't want someone accidentally using the min to store data they care about, but I see the utility of it. @davidlago let's hurry up and get security into core :) Is there anything else we can do to make it really, really clear "only use this for testing/dev"? |
you could in general add a README file to the distribution ZIPs which give a quick-start for them. for min it could say "this has no security built in, we strongly recommend you use the full distribution unless you know exactly what you're doing", and for both of them it could give some links to the quick-start guide in the documentation? |
Just a thought how about in the startup logs? A warning message that throws a CAUTION message (just for min artifact), but this should have a code added to the min distribution. |
how do you know if you have a security plugin or not? unless you have some "is security plugin enabled" API which the security plugin has to implement to tell OpenSearch that it's there? it might not be the OpenSearch Security plugin which is running and providing it, so you also can't just filter the plugin list to check it. |
Some mechanism if its not a full bundle vs min, if not full bundle then add a message. |
but we're not using a full bundle but still add OpenSearch Security. i don't want a warning in that case (probably nobody would notice it... but if somebody does, good luck trying to explain to them why they get a warning on startup about missing security even though security is in place) |
@CEHENKLE want to write up an issue in OpenSearch that says "help users understand they should not use min without security"? I propose not to over-engineer this and spend all our time doing what's best for users, ie. having security enabled by default in core so that those who disable it do it deliberately. |
note: once #99 is fully implemented the no-jdk version of the distribution should be published to maven as part of this step here. |
Is your feature request related to a problem? Please describe
currently, automated builds (e.g. of in-house docker images) don't have a good way to automatically pull in the
.tar.gz
file of the minimal distribution: the artifact is just offered via HTTPS, the link has to be known.Describe the solution you'd like
the minimal distribution artifact (e.g. https://artifacts.opensearch.org/releases/core/opensearch/1.3.1/opensearch-min-1.3.1-linux-x64.tar.gz) should be published to maven.
that way, automated build systems can be used to pull in the artifact w/o having to know an exact URL or requiring direct internet access (it can then go via an in-house maven server which serves as a proxy and also caches the artifact for later re-use).
since maven artifacts can be accessed using HTTP(S) this also means that this could - theoretically - even be used as the primary download location in the future (i.e. replacing the current download paths for (new) artifacts).
Describe alternatives you've considered
any form of using HTTP(S) fails for several reasons:
there would be workarounds, e.g. having a dedicated proxy server for this, but that'd be a huge overkill and would require this to be in place everywhere rather than just having the artifacts deployed to maven once.
Additional context
The text was updated successfully, but these errors were encountered: