Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Replace $JOB_NAME with $JOB_BASE_NAME in all jenkinsfiles and libs #1394

Closed
peterzhuamazon opened this issue Dec 21, 2021 · 3 comments
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.

Comments

@peterzhuamazon
Copy link
Member

We currently use $JOB_NAME which runs well if we only have everything in the root directory.

However, once we starts to create folders in Jenkins and separate jobs with these folders, $JOB_NAME will leads to the full path of the job, not just name.

This can leads to issues and break our current setup on S3 and more.

JOB_NAME
    Name of the project of this build, such as "foo" or "foo/bar".
JOB_BASE_NAME
    Short Name of the project of this build stripping off folder paths, such as "foo" for "bar/foo".

I suggest we make this change and open to other ideas.

Thanks.

@dblock
Copy link
Member

dblock commented Dec 21, 2021

Makes sense to me, I didn’t know that the name inherited the path.

@abhinavGupta16 abhinavGupta16 added bug Something isn't working good first issue Good for newcomers labels Jan 4, 2022
@peterzhuamazon peterzhuamazon added enhancement New Enhancement and removed bug Something isn't working labels Jul 25, 2022
@bbarani bbarani added the hacktoberfest Global event that encourages people to contribute to open-source. label Oct 5, 2022
@ScreamingPigeon
Copy link

ScreamingPigeon commented Oct 4, 2023

I can work on this issue. As I understand this would involve making changes to all the files ending with .groovy in the ./tests/jenkins/ directory. I am curious though about the exact issues caused by using the full path instead of the name

@peterzhuamazon
Copy link
Member Author

As of now we have not make folders in our setups, but rather views.
This is a very low priority task for now.
And we will close it for the time being. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.
Projects
None yet
Development

No branches or pull requests

5 participants