From 444228fb066548f81ae85e27c966c614b18303e5 Mon Sep 17 00:00:00 2001 From: Yaliang Wu Date: Thu, 16 Feb 2023 22:56:59 -0800 Subject: [PATCH] address comments Signed-off-by: Yaliang Wu --- .../ml/common/transport/upload/MLUploadInput.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/common/src/main/java/org/opensearch/ml/common/transport/upload/MLUploadInput.java b/common/src/main/java/org/opensearch/ml/common/transport/upload/MLUploadInput.java index 70ee4a4ba8..279528bc32 100644 --- a/common/src/main/java/org/opensearch/ml/common/transport/upload/MLUploadInput.java +++ b/common/src/main/java/org/opensearch/ml/common/transport/upload/MLUploadInput.java @@ -73,18 +73,14 @@ public MLUploadInput(FunctionName functionName, if (version == null) { throw new IllegalArgumentException("model version is null"); } - //TODO: enable prebuilt model in 2.6 + if (modelFormat == null) { + throw new IllegalArgumentException("model format is null"); + } if (url != null) { - if (modelFormat == null) { - throw new IllegalArgumentException("model format is null"); - } if (modelConfig == null) { throw new IllegalArgumentException("model config is null"); } } - if (modelFormat == null) { - throw new IllegalArgumentException("model format is null"); - } this.modelName = modelName; this.version = version; this.description = description;