Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix doc_values default value in a number of field types #5615

Closed
1 of 4 tasks
harshavamsi opened this issue Nov 16, 2023 · 4 comments · Fixed by #5619
Closed
1 of 4 tasks

[DOC] Fix doc_values default value in a number of field types #5615

harshavamsi opened this issue Nov 16, 2023 · 4 comments · Fixed by #5619
Assignees
Labels
3 - Done Issue is done/complete Sev3 Medium priority. Content that's missing, driven by dev, PM or the community.

Comments

@harshavamsi
Copy link
Contributor

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Similar to #5451, we should fix the default doc_values in a bunch of places.

For number fields - doc_values are true by default
Similar with boolean fields - doc_values are true by default
Similar with date fields -- doc_values are true by
Similar with ip field -- doc_values are true by default

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@hdhalter
Copy link
Contributor

Thanks for creating this issue, @harshavamsi ! Just confirming that these changes are also relevant starting in 2.12?

@harshavamsi
Copy link
Contributor Author

Hi @hdhalter these have always been the case since the initial fork, just the the documentation reflected differently. I don't think we would need to tie this to a release.

@hdhalter hdhalter added Sev3 Medium priority. Content that's missing, driven by dev, PM or the community. 1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR. and removed untriaged labels Nov 16, 2023
@hdhalter hdhalter added 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed 1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR. labels Nov 16, 2023
@hdhalter
Copy link
Contributor

@harshavamsi - Can you please submit PRs for these changes?

@harshavamsi
Copy link
Contributor Author

Raised #5619

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Done Issue is done/complete and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. 2 - In progress Issue/PR: The issue or PR is in progress. labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete Sev3 Medium priority. Content that's missing, driven by dev, PM or the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants