Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][DocBot] Move variables into function declarations cluster_bootstrap.py #65

Open
dtaivpp opened this issue Oct 23, 2023 · 2 comments
Open

[FEATURE][DocBot] Move variables into function declarations cluster_bootstrap.py #65

dtaivpp opened this issue Oct 23, 2023 · 2 comments
Assignees
@LucasWang750
Labels
enhancement New feature or request help wanted Extra attention is needed OSCI

Comments

@dtaivpp
Copy link
Collaborator

dtaivpp commented Oct 23, 2023

Is your feature request related to a problem?

When we have parameters hidden in our files we cannot as easily test our changes. To make this code more testable we need to pull things like index names into the function parameters and we can set them as defaults if that makes sense.

https://github.com/opensearch-project/demos/pull/60/files#r1368887197
@dtaivpp dtaivpp added enhancement New feature or request untriaged Issues not seen by a maintainer yet. labels Oct 23, 2023
@LucasWang750
Copy link

I would like to take this issue

@LucasWang750 LucasWang750 mentioned this issue Oct 26, 2023
Closed
@dtaivpp
Copy link
Collaborator Author

dtaivpp commented Oct 28, 2023

Assigned and will review the PR here shortly

@dtaivpp dtaivpp added help wanted Extra attention is needed OSCI and removed untriaged Issues not seen by a maintainer yet. labels Oct 29, 2023
@LucasWang750 LucasWang750 mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucasWang750 LucasWang750

Labels
enhancement New feature or request help wanted Extra attention is needed OSCI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtaivpp @LucasWang750