From b33ddca28c05cb2c2b456d666ef255260ded1f27 Mon Sep 17 00:00:00 2001 From: Rishikesh1159 Date: Thu, 24 Feb 2022 17:54:51 +0000 Subject: [PATCH 1/2] Adding uasage and external property customDistributionUrl to let developer override default distribution Download url Signed-off-by: Rishikesh1159 --- DEVELOPER_GUIDE.md | 14 +++++++++++++- build.gradle | 1 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index a9db88d91..035529368 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -8,6 +8,9 @@ - [Building from the IDE](#building-from-the-ide) - [Debugging](#debugging) - [Advanced: Launching multi node clusters locally](#advanced-launching-multi-node-clusters-locally) + - [Backports](#backports) + - [Gradle Plugins](#gradle-plugins) + - [Distribution Download Plugin](#distribution-download-plugin) ## Developer Guide @@ -87,4 +90,13 @@ The Github workflow in [`backport.yml`](.github/workflows/backport.yml) creates original PR with an appropriate label `backport ` is merged to main with the backport workflow run successfully on the PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label `backport 1.x` to the PR and make sure the backport workflow runs on the PR along with other checks. Once this PR is -merged to main, the workflow will create a backport PR to the `1.x` branch. \ No newline at end of file +merged to main, the workflow will create a backport PR to the `1.x` branch. + +### Gradle Plugins + +#### Distribution Download Plugin + +The Distribution Download plugin downloads the latest version of OpenSearch by default, and supports overriding this behavior by setting `customDistributionUrl`. +``` +./gradlew integTest -DcustomDistributionUrl="https://ci.opensearch.org/ci/dbc/bundle-build/1.2.0/1127/linux/x64/dist/opensearch-1.2.0-linux-x64.tar.gz" +``` diff --git a/build.gradle b/build.gradle index f4d353204..47c04718b 100644 --- a/build.gradle +++ b/build.gradle @@ -68,6 +68,7 @@ apply plugin: 'eclipse' ext { isSnapshot = "true" == System.getProperty("build.snapshot", "true") + customDistributionUrl = System.getProperty("customDistributionUrl") } allprojects { From d3f412ce3519093cb078400799def42251bf64b1 Mon Sep 17 00:00:00 2001 From: Rishikesh1159 Date: Tue, 5 Jul 2022 19:40:10 +0000 Subject: [PATCH 2/2] Adding doc and removing system property from build.gradle Signed-off-by: Rishikesh1159 --- DEVELOPER_GUIDE.md | 4 ++-- build.gradle | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index 035529368..ef9460fb4 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -96,7 +96,7 @@ merged to main, the workflow will create a backport PR to the `1.x` branch. #### Distribution Download Plugin -The Distribution Download plugin downloads the latest version of OpenSearch by default, and supports overriding this behavior by setting `customDistributionUrl`. +The Distribution Download plugin downloads the latest version of OpenSearch by default, and supports overriding this behavior by setting `customDistributionUrl`. This will help to pull artifacts from custom location for testing during release process. ``` -./gradlew integTest -DcustomDistributionUrl="https://ci.opensearch.org/ci/dbc/bundle-build/1.2.0/1127/linux/x64/dist/opensearch-1.2.0-linux-x64.tar.gz" +./gradlew integTest -PcustomDistributionUrl="https://ci.opensearch.org/ci/dbc/bundle-build/1.2.0/1127/linux/x64/dist/opensearch-1.2.0-linux-x64.tar.gz" ``` diff --git a/build.gradle b/build.gradle index 47c04718b..f4d353204 100644 --- a/build.gradle +++ b/build.gradle @@ -68,7 +68,6 @@ apply plugin: 'eclipse' ext { isSnapshot = "true" == System.getProperty("build.snapshot", "true") - customDistributionUrl = System.getProperty("customDistributionUrl") } allprojects {