Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test SegmentReplicationRelocationIT.testPrimaryRelocation is flaky. #8858

Closed
mch2 opened this issue Jul 25, 2023 · 0 comments · Fixed by #8859
Closed

[BUG] Test SegmentReplicationRelocationIT.testPrimaryRelocation is flaky. #8858

mch2 opened this issue Jul 25, 2023 · 0 comments · Fixed by #8859
Assignees
Labels
bug Something isn't working

Comments

@mch2
Copy link
Member

mch2 commented Jul 25, 2023

#8827 (comment)

This test is failing due to a deadlock situation introduced with this PR because of the introduced blocking refresh. This is because this method is holding the metadataLock on the store while invoking consumer.accept(buildSegmentInfos(infosBytes, segmentsGen)); which loads the newly built SegmentInfos onto the DirectoryReader and invokes maybeRefreshBlocking. If a concurrent scheduled refresh is invoked before updateSegments is able to aquire the refresh lock, it will block until the scheduled refresh completes, however if the scheduled refresh swaps the SegmentInfos reference it will decRef the previous DirectoryReader that in turn tries to blockingly acquire the metadataLock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant