Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OnDemandBlockSnapshotIndexInputTests fail on Windows. #5396

Open
mch2 opened this issue Nov 29, 2022 · 2 comments
Open

[BUG] OnDemandBlockSnapshotIndexInputTests fail on Windows. #5396

mch2 opened this issue Nov 29, 2022 · 2 comments
Labels
bug Something isn't working CI CI related :test Adding or fixing a test windows

Comments

@mch2
Copy link
Member

mch2 commented Nov 29, 2022

Describe the bug
OnDemandBlockSnapshotIndexInputTests.testVariousBlockSize fails on windows. See https://build.ci.opensearch.org/job/gradle-check/7153/testReport/junit/org.opensearch.index.store.remote.file/OnDemandBlockSnapshotIndexInputTests/testVariousBlockSize/

Expected behavior
Test should pass.

Plugins
None

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
The test is failing to delete files in its cleanDirectory method because it uses an MMapDirectory. Attempts to delete the files throw an AccessDeniedException unless the IndexInput is closed & a round of gc runs.
See https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java#LL46C4-L46C4

@mch2 mch2 added bug Something isn't working untriaged labels Nov 29, 2022
@mch2
Copy link
Member Author

mch2 commented Nov 29, 2022

A couple options.

  1. If running on windows, force a gc run in the test after the input is closed.
  2. We ignore the test on Windows...

@mch2
Copy link
Member Author

mch2 commented Nov 29, 2022

Submit a PR to skip this for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CI related :test Adding or fixing a test windows
Projects
None yet
Development

No branches or pull requests

2 participants