[BUG] High primary shard weight lead to uneven shard distribution

[Arpit-Bandejiya]

Describe the bug

We have seen that due to high weight assigned to due to Primary Balance constraint. The nodes with heavy weights never recieve a replica shard and cause uneven shard distribution.

Related component

Other

To Reproduce

Created 100 indices with 100p and 1replica setting.

Expected behavior

The shards should be evenly distributed.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

• OS: [e.g. iOS]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[HUSTERGS]

May I ask why the high weight will cause the uneven shard distribution?
After my test, it seems because the high weight will occupy nearly all precision of float, thus the how uneven is the index during the balance phase is no longer accurate, after I change all the float to double, the problem is gone.
If there’s anything wrong with what I said, please feel free to point it out. I really appreciate it. :)
@Arpit-Bandejiya

[HUSTERGS]

May I ask why the high weight will cause the uneven shard distribution? After my test, it seems because the high weight will occupy nearly all precision of float, thus the how uneven is the index during the balance phase is no longer accurate, after I change all the float to double, the problem is gone. If there’s anything wrong with what I said, please feel free to point it out. I really appreciate it. :) @Arpit-Bandejiya

And I see the #16471 try to lower the constrain weight, but the weight for INDEX_SHARD_PER_NODE_BREACH_CONSTRAINT_ID and INDEX_PRIMARY_SHARD_BALANCE_CONSTRAINT_ID remain the old settings, that is 1000000L, which I guess may have similar problem.