Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DerivedFieldFetchAndHighlightTests has flaky tests #13249

Closed
mch2 opened this issue Apr 16, 2024 · 5 comments · Fixed by #13313
Closed

[BUG] DerivedFieldFetchAndHighlightTests has flaky tests #13249

mch2 opened this issue Apr 16, 2024 · 5 comments · Fixed by #13313
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc

Comments

@mch2
Copy link
Member

mch2 commented Apr 16, 2024 •
edited by peternied
Loading

Describe the bug

From #13248 (comment)

testDerivedFieldFromIndexMapping and testDerivedFieldFromSearchMapping are flaky.

These look recently introduced with #12850 @rishabhmaurya and/or @msfroh Can you please take a look?

Related component

Search

To Reproduce

N/A

Expected behavior

Tests should pass

Additional Details

N/A
@mch2 mch2 added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels Apr 16, 2024
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Apr 16, 2024
@mch2 mch2 mentioned this issue Apr 16, 2024
Merged
8 tasks
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7]
@mch2 Thanks for filing this issue

@rishabhmaurya
Copy link
Contributor

@mch2 thanks for reporting. I will take it forward.

@froh
Copy link

froh commented Apr 19, 2024

@msfroh, not @froh ...

@rishabhmaurya rishabhmaurya mentioned this issue Apr 19, 2024
Merged
6 tasks
@rishabhmaurya
Copy link
Contributor

rishabhmaurya commented Apr 19, 2024 •
edited
Loading

@mch2 please review #13313 thanks

@mch2
Copy link
Member Author

mch2 commented Apr 20, 2024

@msfroh, not @froh ...

Oops sorry about that!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc
Projects
Search Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the flaky test for derived fields highlighter test rishabhmaurya/OpenSearch
4 participants
@froh @mch2 @peternied @rishabhmaurya