Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated the approval workflow checks #108

Closed
3 of 4 tasks
peternied opened this issue Feb 18, 2021 · 2 comments
Closed
3 of 4 tasks

Automated the approval workflow checks #108

peternied opened this issue Feb 18, 2021 · 2 comments
Assignees
@peternied
Labels
CI CI related documentation Improvements or additions to documentation

Comments

@peternied
Copy link
Member

peternied commented Feb 18, 2021 •
edited
Loading

Documenting and automating the approval process according to CONTRIBUTING.md

Automated checks

  • Squash / merge is already covered by the repo settings
  • Require 2 1 approval(s) before merge
  • Require DOC signature https://developercertificate.org/
  • ... other requirements
@peternied peternied added documentation Improvements or additions to documentation CI CI related labels Feb 18, 2021
@peternied peternied mentioned this issue Feb 18, 2021
Merged
@peternied
Copy link
Member Author

RE: Require 2 approval(s) before merge

[Offline recap] Back and forth, we want to be open to more pull requests. 1 vs 2 is arbitrary, being that we can modify this later - let's be more permissive in the near term by going with 1 committer approving.

@peternied peternied self-assigned this Feb 19, 2021
@peternied
Copy link
Member Author

We can reopen a specific issue if it comes up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peternied peternied

Labels
CI CI related documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peternied