Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leader/follower checker timeouts cannot be dynamically set #10377

Closed
jainankitk opened this issue Oct 5, 2023 · 4 comments · Fixed by #10528
Closed

Leader/follower checker timeouts cannot be dynamically set #10377

jainankitk opened this issue Oct 5, 2023 · 4 comments · Fixed by #10528
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers

Comments

@jainankitk
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, the leader/follower checker timeouts can only be statically set using the yml settings. That is unnecessary and too constraining.

Describe the solution you'd like
Allow leader/follower checker timeouts to be dynamically set

@jainankitk jainankitk added enhancement Enhancement or improvement to existing feature or request untriaged good first issue Good for newcomers labels Oct 5, 2023
@dblock
Copy link
Member

dblock commented Oct 5, 2023

@jainankitk What's a real world scenario where you'd want to change those without restarting the node(s)?

@jainankitk
Copy link
Collaborator Author

What's a real world scenario where you'd want to change those without restarting the node(s)?

@dblock - This is not only useful for changing the value without restarting the nodes. It allows convenient override value without changing the yml on tens of nodes for large cluster.

This was also called out as must have during Opensearch Con by OCI for 750 node cluster

@dblock
Copy link
Member

dblock commented Oct 10, 2023

Okay, a 750 node cluster is no small feat. +1

@shwetathareja
Copy link
Member

+1, this would be useful for large clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants