From 1052eadb9333aa826461b5946a5f5aedf79f5827 Mon Sep 17 00:00:00 2001
From: Bharathwaj G <bharath78910@gmail.com>
Date: Mon, 19 Aug 2024 20:26:46 +0530
Subject: [PATCH] addressing comments

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
---
 .../main/java/org/opensearch/index/mapper/StarTreeMapper.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java b/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java
index 65e05256042cc..93764e93ae30d 100644
--- a/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java
+++ b/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java
@@ -285,7 +285,7 @@ private void addBaseMetrics(MetricStat metricStat, Set<MetricStat> metricSet) {
                 Queue<MetricStat> metricQueue = new LinkedList<>(metricStat.getBaseMetrics());
                 while (metricQueue.isEmpty() == false) {
                     MetricStat metric = metricQueue.poll();
-                    if (metric.isDerivedMetric()) {
+                    if (metric.isDerivedMetric() && !metricSet.contains(metric)) {
                         metricQueue.addAll(metric.getBaseMetrics());
                     }
                     metricSet.add(metric);