From 67b47f803721685d22e56cd9451ffda0a4ba0f33 Mon Sep 17 00:00:00 2001 From: Joey Liu Date: Wed, 29 Jan 2025 21:17:59 +0000 Subject: [PATCH 1/3] [Discover] chore: Improve scrolling experience Signed-off-by: Joey Liu --- .../public/application/components/chart/_histogram.scss | 2 ++ .../components/default_discover_table/_doc_table.scss | 7 +++++++ .../view_components/canvas/discover_canvas.scss | 2 ++ 3 files changed, 11 insertions(+) diff --git a/src/plugins/discover/public/application/components/chart/_histogram.scss b/src/plugins/discover/public/application/components/chart/_histogram.scss index f30d24d0bb45..816b97b6d929 100644 --- a/src/plugins/discover/public/application/components/chart/_histogram.scss +++ b/src/plugins/discover/public/application/components/chart/_histogram.scss @@ -14,6 +14,8 @@ border-bottom: 1px solid $euiColorLightShade; padding: 8px; gap: 8px; + flex-grow: 0; + flex-wrap: nowrap; .dscChart__chartheader { align-items: center; diff --git a/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss b/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss index 1e780a7e4d8a..08aa9422cfbb 100644 --- a/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss +++ b/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss @@ -128,6 +128,13 @@ doc-table { } .osd-table { + thead { + position: sticky; + top: 0; + background-color: white; + z-index: 1; + } + // sub tables should not have a leading border .table .table { margin-bottom: 0; diff --git a/src/plugins/discover/public/application/view_components/canvas/discover_canvas.scss b/src/plugins/discover/public/application/view_components/canvas/discover_canvas.scss index beac224ec6ba..01ca9d48ecb6 100644 --- a/src/plugins/discover/public/application/view_components/canvas/discover_canvas.scss +++ b/src/plugins/discover/public/application/view_components/canvas/discover_canvas.scss @@ -6,6 +6,8 @@ /* stylelint-disable-next-line */ container-name: canvas; height: 100%; + display: flex; + flex-direction: column; &_results { margin-left: $euiSizeM; From 08de961d9782c73e4ca663ce7a16994a969e1b64 Mon Sep 17 00:00:00 2001 From: "opensearch-changeset-bot[bot]" <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Date: Wed, 29 Jan 2025 21:37:49 +0000 Subject: [PATCH 2/3] Changeset file for PR #9298 created/updated --- changelogs/fragments/9298.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/9298.yml diff --git a/changelogs/fragments/9298.yml b/changelogs/fragments/9298.yml new file mode 100644 index 000000000000..536db226fcff --- /dev/null +++ b/changelogs/fragments/9298.yml @@ -0,0 +1,2 @@ +feat: +- Improve scrolling experience on Discover page. ([#9298](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9298)) \ No newline at end of file From 7f8d801a541c37b0a3fe9158a2a5c83cf44ad6ef Mon Sep 17 00:00:00 2001 From: Joey Liu Date: Sat, 1 Feb 2025 00:46:56 +0000 Subject: [PATCH 3/3] [Discover] chore: Improve scrolling experience Signed-off-by: Joey Liu --- .../components/default_discover_table/_doc_table.scss | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss b/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss index 08aa9422cfbb..b8131c09d5e6 100644 --- a/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss +++ b/src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss @@ -128,10 +128,16 @@ doc-table { } .osd-table { + border-collapse: separate; + + tr:first-child td { + border-top: none; + } + thead { position: sticky; top: 0; - background-color: white; + background-color: $euiColorEmptyShade; z-index: 1; }