Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Eslint does not allow to add snake_case, new gitignore which adds opensearch-dashboards-docker-dev has snake_case .yml file #3765

Open
Aigerim-ai opened this issue Apr 2, 2023 · 2 comments
Labels
bug Something isn't working devex OSCI Open Source Contributor Initiative

Comments

@Aigerim-ai
Copy link
Contributor

Aigerim-ai commented Apr 2, 2023

Hello I fixed .gitignore file
from [FIX]gitignore #3762
But now I have following error, we need to rename our autogenerated file docker-compose.yml (Docker installation) in order for our commit to pass elsint check

Should I create separate issue for renaming our docker-compose.yml?

@Aigerim-ai Aigerim-ai added bug Something isn't working untriaged labels Apr 2, 2023
@Aigerim-ai
Copy link
Contributor Author

Screenshot 2023-04-02 at 13 41 15

@Aigerim-ai Aigerim-ai mentioned this issue Apr 4, 2023
8 tasks
@joshuarrrr
Copy link
Member

If I remember correctly, docker-compose.yml is the conventional name for that type of file. In which case we should add an exception for that file or directory. Take a look at src/dev/precommit_hook/casing_check_config.js, which defines those rules.

@joshuarrrr joshuarrrr added devex OSCI Open Source Contributor Initiative and removed untriaged labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devex OSCI Open Source Contributor Initiative
Projects
None yet
Development

No branches or pull requests

2 participants