Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Issues with RegionMaps plugin #2888

Closed
VladutZzZ opened this issue Nov 17, 2022 · 3 comments
Closed

[Bug] Issues with RegionMaps plugin #2888

VladutZzZ opened this issue Nov 17, 2022 · 3 comments
Assignees
Labels
bug Something isn't working maps Issues or PRs related to the Maps Service

Comments

@VladutZzZ
Copy link

Hello,

I think I found multiple issues with region maps after adding support for custom import map vector.

First, from debugging the current code, looks like if you chose default map you can't use Name as join Field and iso_3166_2 is default selected:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/region_map/public/region_map_visualization.js#L159

And the second one is using custom vector map, when getting vector map, size is not set so only first 10 Features are returned.
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/region_map/server/routes/opensearch.ts#L67
I got all results by adding size in params:
const params = { index, body: {} ,size: 30};

Thank you

@kavilla kavilla added the maps Issues or PRs related to the Maps Service label Nov 17, 2022
@joshuarrrr joshuarrrr added bug Something isn't working untriaged labels Nov 17, 2022
@joshuarrrr joshuarrrr changed the title Issues with RegionMaps plugin [Bug] Issues with RegionMaps plugin Nov 17, 2022
@AbhishekReddy1127
Copy link
Contributor

Hi @VladutZzZ for the first, it is getting updated with Name. Could you provide any small snippet of what you were describing so that, we can have some clear picture about it..

Screen.Recording.2022-12-14.at.7.59.09.PM.mov

For the second, I am not sure if it’s a bug since the request number is using by default. Could you provide more detailed information , so that we could look into it.

@VladutZzZ
Copy link
Author

VladutZzZ commented Dec 21, 2022

Hi,
For the first bug, it's not an UI bug, you can change it on UI and will change, the problem is on backend and you could see if you have some data in that index with countries name and will not show any result, only warnings like "{CountryName} join field" and you could see in backend that ISO 3166-1-alpha-2 Code is used even if on UI you selected Name.

For the second one, why shouldn't be a bug if you can set that value?
For example you import your custom geojson with 50 countries and from that geojson will be retreived only the first 10 entries because default is used and on UI you can't override that value in this case.

Thanks

@kavilla
Copy link
Member

kavilla commented Jan 3, 2023

Issue moved to opensearch-project/dashboards-maps #156 via Zenhub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maps Issues or PRs related to the Maps Service
Projects
None yet
Development

No branches or pull requests

5 participants