Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML editing button in SampledValueControl affected by label #673

Closed
danyill opened this issue Apr 5, 2022 · 1 comment · Fixed by #703
Closed

XML editing button in SampledValueControl affected by label #673

danyill opened this issue Apr 5, 2022 · 1 comment · Fixed by #703
Assignees
@JakobVogelsang
Labels
Kind: Bug Something isn't working Status: Ready for development Checked by all co-developers
Milestone
Sprint 2022-04-29

Comments

@danyill
Copy link
Collaborator

danyill commented Apr 5, 2022

Describe the bug

In the recent SampledValueControl edit wizard, if Pro mode is enabled the edit/show XML screen styling is affected by the label

To Reproduce

Steps to reproduce the behavior:

  1. Open a file with sampled values
  2. In the substation editor click on the (S) menu
  3. Select a SampledValueControl
  4. See error (screenshot below).

Expected behavior

The edit button is visually distinguished from the title.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: Version 98.0.4758.102 (Official Build) (64-bit)
@danyill danyill added the Kind: Bug Something isn't working label Apr 5, 2022
@Sander3003
Copy link
Member

Solution: wider the screen to make it fit.

@Sander3003 Sander3003 added the Status: Ready for development Checked by all co-developers label Apr 11, 2022
@Sander3003 Sander3003 added this to the Sprint 2022-04-29 milestone Apr 25, 2022
@JakobVogelsang JakobVogelsang linked a pull request Apr 25, 2022 that will close this issue
fix(wizard-dialog): avoid header overlap with extra action buttons #703
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakobVogelsang JakobVogelsang

Labels
Kind: Bug Something isn't working Status: Ready for development Checked by all co-developers
Projects
None yet
Milestone
Sprint 2022-04-29
Development

Successfully merging a pull request may close this issue.

fix(wizard-dialog): avoid header overlap with extra action buttons openscd/open-scd
3 participants
@danyill @Sander3003 @JakobVogelsang