Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IED names #453

Closed
randy993 opened this issue Dec 21, 2021 · 5 comments · Fixed by #494
Closed

Change IED names #453

randy993 opened this issue Dec 21, 2021 · 5 comments · Fixed by #494
Assignees
Labels
Kind: Enhancement New Request Status: Help wanted Extra attention is needed

Comments

@randy993
Copy link

randy993 commented Dec 21, 2021

As an engineer I want to be able to change the IED names so I import ICD files and change the IED template name to a production name.

  • Create edit button in the IED editor (after dropdown menu)
  • Create edit button in substation tab upon selecting an IED
  • Create IED edit window
    image
  • Create checks
    -- for uniqueness, the user should only be able to save the IED name when there is no other IED with the same name
    -- Name can't be empty
    -- Name should be according to the pattern
<xs:simpleType name="tIEDName"> 
  <xs:restriction base="tAcsiName"> 
    <xs:maxLength value="64"/> 
    <xs:pattern value="[A-Za-z][0-9A-Za-z_]{0,2}"/> 
    <xs:pattern value="[A-Za-z][0-9A-Za-z_]{4,63}"/> 
    <xs:pattern value="[A-MO-Za-z][0-9A-Za-z_]{3}"/> 
    <xs:pattern value="N[0-9A-Za-np-z_][0-9A-Za-z_]{2}"/> 
    <xs:pattern value="No[0-9A-Za-mo-z_][0-9A-Za-z_]"/> 
    <xs:pattern value="Non[0-9A-Za-df-z_]"/> 
  </xs:restriction> 
</xs:simpleType>
  • Change the IED name and all references to the IED upon saving in the following locations
    -- TConnectedAP.tUnNaming
    -- agLDRef
    -- tLNode.tUnNaming
    -- tIED.tUnNaming
    -- tExtRef
    -- tControlWithIEDName.tControl.IEDName

Background:
This could be done in the IED editor or somewhere else if that makes more sense. All references to this IED need to be changed as well.

@randy993
Copy link
Author

@JakobVogelsang Could you add this issue to the IED editor project?

@randy993
Copy link
Author

Will we also make the description editable? If so, in what places should this be updated?

@Sander3003
Copy link
Member

The description does not need to be editable in this story.

@dlabordus
Copy link
Contributor

dlabordus commented Jan 18, 2022

The following reference to the IED Name are updated.
The attribute (between []) of the following elements:

  • Association[iedName]
  • ClientLN[iedName]
  • ConnectedAP[iedName]
  • ExtRef[iedName]
  • KDC[iedName]
  • LNode[iedName]

The Text Content of the following elements:

  • GSEControl > IEDName
  • SampledValueControl > IEDName

Private Elements are ignored, but this can become a problem in the future.
Not sure how to make a bulletproof way to do this...

@Sander3003
Copy link
Member

It is fine to ignore the private types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Enhancement New Request Status: Help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants