Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different panzoom implementation #414

Closed
JakobVogelsang opened this issue Dec 8, 2021 · 3 comments
Closed

Use different panzoom implementation #414

JakobVogelsang opened this issue Dec 8, 2021 · 3 comments
Labels
Kind: Maintenance Maintaining tasks within OpenSCD

Comments

@JakobVogelsang
Copy link
Collaborator

The panzoom library we currently use is written with CommonJS import style and we cannot import is in our tests.
@Flurb
Copy link
Contributor

Flurb commented Dec 8, 2021

@ca-d gave an option written in Typescript: https://github.com/timmywil/panzoom

But this library isn't compatible with shadow DOM, there is an issue about this: timmywil/panzoom#536

I'm not sure when it can be fixed, maybe we can try to fix it.
Otherwise, I haven't checked other options.

@Flurb
Copy link
Contributor

Flurb commented Dec 8, 2021 •
edited
Loading

@JakobVogelsang @ca-d This should be fixed in order to continue #403, what is the best way to continue this?

@JakobVogelsang
Copy link
Collaborator Author

We decided to not add the test that imports panzoom. So this is not a blocking issue

@JakobVogelsang JakobVogelsang added Kind: Maintenance Maintaining tasks within OpenSCD Reviewed: Prioritized labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind: Maintenance Maintaining tasks within OpenSCD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Flurb @JakobVogelsang