-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jackson-module-kotlin as a required dependency #1722
Comments
Unfortunately, There might be a fix on the Jackson side: FasterXML/jackson-module-kotlin#566 (comment) This effectively pins recipes run via Maven plugin (haven't checked Gradle) to Kotlin 1.5.30. I wonder if it might be better to 1) dependency-manage kotlin-bom in the maven plugin, assuming that a pinned current version is better than a pinned stale version 2) remove |
Aside from the issue on Jackson-module-kotlin side which hopefully gets addressed, module itself does work against kotlin-core versions 1.4 - 1.8, doesn't it? At least that is my understanding, based on CI checking against different versions of |
I'm not aware of any compatibility issues between the code of |
@nmck257 Ok yes that is my understanding as well. The issue linked-to needs to be resolved regardless, of course. |
We want to support the serialization and deserialization of kotlin recipes.
We do not want rewrite to have an opinion about which version of kotlin its consumers use, if they use kotlin at all.
So we shall remove our dependency on jackson-module-kotlin and use reflection to apply it at runtime if it is present. Build plugins will be correspondingly updated to include jackson-module-kotlin by default, so users will have to make no changes.
The text was updated successfully, but these errors were encountered: