Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook method for LogoRef Urls #929

Closed
svareg opened this issue Oct 29, 2019 · 3 comments
Closed

Hook method for LogoRef Urls #929

svareg opened this issue Oct 29, 2019 · 3 comments
Assignees

Comments

@svareg
Copy link
Collaborator

svareg commented Oct 29, 2019

Hello,

When we generate a xml or json extract, the hook method get_symbol_ref() is called. The configuration allow us to overwrite this method with our own, so that we can control which URL are used and published in the extract. This is very cool, because it allows us to set "extern" urls in extract, while using "intern" urls in our code (because we have sometimes complex proxies configuration)

Unfortunately, this does not work for the following attributes :

  • LogoPLRCadastreRef
  • FederalLogoRef
  • CantonalLogoRef
  • MunicipalityLogoRef

In the code, a simple self._request.route_url() is called.
The consequences for us is that the published urls are using internal IP adresses.

grafik

Could it be possible to have the same behaviour here, with an overwritable hook method get_logo_ref() instead of a simple route_url() call ?

What do you think ?
Thanks!

@vvmruder vvmruder assigned vvmruder and svamaa and unassigned vvmruder Dec 15, 2022
@lopo977
Copy link
Collaborator

lopo977 commented Dec 20, 2022

Overwritable hook method get_logo_ref() could be a nice feature.
Please we are still using the reference implementation. (Tessin)
Keep attention in implementing dynamic binding to a new overridable implementation via configuration (strategy pattern).
Thank you.

@peterschaer
Copy link
Collaborator

We would also welcome this feature and would also be willing to contribute in some way.

@svamaa svamaa added the 2023 label Jan 26, 2023
@jwkaltz
Copy link
Member

jwkaltz commented Jun 12, 2023

@svamaa this can be closed as per #1744, right?

@svamaa svamaa closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants