Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS review: Performance #89

Open
mdpiper opened this issue Mar 8, 2021 · 2 comments
Open

JOSS review: Performance #89

mdpiper opened this issue Mar 8, 2021 · 2 comments

Comments

@mdpiper
Copy link

mdpiper commented Mar 8, 2021

This issue is raised in reference to JOSS submission 3052.

There's an unsubstantiated performance claim on line 48 of the manuscript. The claim should be backed up with data or struck.
@mdpiper
Copy link
Author

mdpiper commented Mar 8, 2021

A suggestion: A quick comparison between ADE and the other techniques might be all that's necessary. E.g.,

We ran ADE, along with approach A and B, over N time slices of a dataset. ADE outperformed the other approaches by a factor of X.

@ayush-1506
Copy link
Member

This definitely looks like something we should add, thanks for raising this! I'll add some benchmarks (performance and speed) on ADE and another approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdpiper @ayush-1506