Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support disable rollout #151

Closed
sumengzs opened this issue Jun 13, 2023 · 3 comments · Fixed by #155
Closed

[feature] support disable rollout #151

sumengzs opened this issue Jun 13, 2023 · 3 comments · Fixed by #155
Assignees

Comments

@sumengzs
Copy link

sumengzs commented Jun 13, 2023

有些情况下,虽然我们的定义并应用了一个rollout资源,但我们并不想启用这个资源,当前场景并不支持此功能,希望能够支持。
Disabledtrue 表示禁用此 Rollout。
禁用时:

  1. Webhook 不会将 workload.Spec.Paused 修改为 true
  2. 当工作负载发生变化时,watch handles 不会将此 Rollout 添加到队列中。
  3. 如果 Rollout 正在运行,它将放弃 Rollout 并重置工作负载更新策略。
  4. 对于相同的工作负载,同一时间只能启用一个 Rollout。但可以存在多个已经被禁用的 Rollout。
// RolloutSpec defines the desired state of Rollout
type RolloutSpec struct {
	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
	// Important: Run "make" to regenerate code after modifying this file
	// Disabled indicates disable this Rollout, Webhook won't modify workload .Spec.Paused to true.
	// Watch handles won't add this rollout to queue when workload changes.
	// If Rollout is running, it will give up rollout and reset workload update strategy.
	// Only one rollout can be enabled for a same workload as the same time.
	Disabled bool
	...
}
@Kuromesi
Copy link
Contributor

/assign

@furykerry
Copy link
Member

furykerry commented Jun 21, 2023

@sumengzs

对于相同的工作负载,同一时间只能启用一个 Rollout。但可以存在多个已经被禁用的 Rollout。

what is the cases of keep multiple disabled rollout? can you share the user story ?

@sumengzs
Copy link
Author

@furykerry

what is the cases of keep multiple disabled rollout? can you share the user story ?

这只是一个扩展能力,不是必须的。多个 rollout 代表了多种策略,用户可以根据需求选择一种策略来使用,当然,用户可以不用如此去做,他可以通过修改原有的 rollout 来达到目的;同时存在的多个被禁用的 rollout 仅仅是提供了选择的能力,如此而已。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants