Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add pod specified-delete for advanced statefulset #951

Closed
wkai886 opened this issue Apr 13, 2022 · 6 comments · Fixed by #1734
Closed

[feature request] Add pod specified-delete for advanced statefulset #951

wkai886 opened this issue Apr 13, 2022 · 6 comments · Fixed by #1734
Labels
help wanted Extra attention is needed kind/feature-request kind/good-first-issue Good for newcomers kind/good-idea Good Idea
Milestone

Comments

@wkai886
Copy link

wkai886 commented Apr 13, 2022

What would you like to be added:

advanced statefulset 添加类似 cloneset 的 在pod 上添加label apps.kruise.io/specified-delete: true 去实现指定pod的重建,并且pod名字不变, 或者 基于 advanced statefulset 的 序号保留扩展下,可以实现重名pod的重建。

Why is this needed:

需要实现 advanced statefulset 的指定 pod重建的时候 能触发 preDelete 的 生命周期hook, 目前通过 序号保留将 某个序号的pod的删除的时候 可以触发 preDelete 的生命周期hook,但是不能覆盖住 同名pod 重建的场景。
如果可以支持 在pod 上添加label apps.kruise.io/specified-delete: true 是最好的,能和cloneset 的 重建逻辑保持一致。

@FillZpp
Copy link
Member

FillZpp commented Apr 13, 2022

/retitle [feature request] Add pod specified-delete for advanced statefulset

@kruise-bot kruise-bot changed the title [feature request] [feature request] Add pod specified-delete for advanced statefulset Apr 13, 2022
@FillZpp
Copy link
Member

FillZpp commented Apr 13, 2022

/assign @veophi

@stale
Copy link

stale bot commented Jul 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 12, 2022
@FillZpp FillZpp removed the wontfix This will not be worked on label Jul 13, 2022
@stale
Copy link

stale bot commented Oct 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 11, 2022
@FillZpp FillZpp removed the wontfix This will not be worked on label Oct 12, 2022
@zmberg zmberg added kind/good-first-issue Good for newcomers kind/good-idea Good Idea labels Feb 20, 2023
@YTGhost
Copy link
Contributor

YTGhost commented Feb 25, 2023

@FillZpp Maybe I can try to take over this job, can you assign this job to me? It would be nice to have some notes or help.

@zmberg
Copy link
Member

zmberg commented Jun 8, 2023

/assign @YTGhost

@zmberg zmberg added the help wanted Extra attention is needed label Jun 8, 2023
@zmberg zmberg added this to the 1.9 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature-request kind/good-first-issue Good for newcomers kind/good-idea Good Idea
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants