-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alexa to the docs #481
Comments
Yes we should! We totally missed to do so. This is related to #62 where I wanted to update the copying of external content. In the meantime we could already improve the content of this README. @mboremski do you see any need for improvements? Best! |
Addition: After a first look it became clear to me, that the article can not be copied 1:1. It contains too many technical details not needed for the general openHAB docs article. I'd say an enhanced version of the second part of the README would be what we need. Would you be interested to build this document? I'd still leave it in the openhab-alexa repo, maybe as a new file USAGE.md. |
sorry for the late reply. I could try to use some useful snipets out of the actual README an write a new one. |
Ehm. I tried around a bit with a USAGE.md file, fount out that to contribute i should make a fork. could you have a look? |
Hi @mboremski, About the workflow:Next step would be to create an pull request to the openhab-alexa repository. Note: Usually changes are made in new branches to prevent conflicts, when several people are working in a project. This keeps your contribution isolated from others and can reduce conflicts. First feedback about style things:I had a first look on that usage file now. We break down texts to one sentence per line. Also there have to be some empty lines between headlines and text parts. Here's an example: So my suggestion for you would be to create a pull request to the openhab alexa repo now and we continue discussion there. |
Excellent answer @Confectrician ! One question I want to answer:
The openHAB project is heavily distributed among dozens of project repos. That is a good thing. Each project is part of openHAB but self-contained for one specific topic, e.g. to host all code related to the openhab-alexa skill. if changes to the skill and its features are planned, the repo should be the one and only place these changes need to be applied. Therefore the README/USAGE document should reside there as well ;) Looking forward to your PR. Please link it here so we can follow along. Thanks for your contribution!! |
Hey @Confectrician hey @ThomDietrich Right now I am joinig gamescom in cologne. |
Made some changes basing on your sugestions @Confectrician and finally made my first pull request. |
Will do that tommorow. :) |
Hey @mboremski, |
Alexa has a "skill" for openHAB (jeah).
https://community.openhab.org/t/official-alexa-smart-home-skill-for-openhab-2/23533
Should we take that to the docs too?
The text was updated successfully, but these errors were encountered: