Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[danfossairunit] Provide more elegant deprecation of channel main#manual_fan_speed #11667

Closed
jlaur opened this issue Nov 29, 2021 · 0 comments · Fixed by #11668
Closed

[danfossairunit] Provide more elegant deprecation of channel main#manual_fan_speed #11667

jlaur opened this issue Nov 29, 2021 · 0 comments · Fixed by #11668
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@jlaur
Copy link
Contributor

jlaur commented Nov 29, 2021

#11147 renamed a channel for consistency and left the old channel for backwards compatibility - "hidden" as an advanced channel.

This was a bit awkward and I've since then learned how this could be achieved in a bit more elegant way. So with this issue I plan to provide a pull request for removing the deprecated channel if no items are linked. If any items are linked, a warning should be logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant