feat: Allow empty params in csv file #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshaowei18
commented
May 6, 2020
| } | ||
|
|
||
| const hasInvalidEmailRecipient = (records: MessageBulkInsertInterface[]): boolean => { | ||
| return records.some((record) => !validator.isEmail(record.recipient)) |
There was a problem hiding this comment.
Not sure if this is the best approach performance wise. I could do this while parsing csv or when we are test hydrating, but it will be messy.
There was a problem hiding this comment.
I think it's fine for now.
lshaowei18
commented
May 6, 2020
| const hasInvalidSmsRecipient = (records: MessageBulkInsertInterface[]): boolean => { | ||
| const re = /^[0-9+]+$/ |
There was a problem hiding this comment.
How strict should I be with this regex?
There was a problem hiding this comment.
If a + exists, it should be at the start of the string.
jeantanzj
reviewed
May 11, 2020
| const hasInvalidSmsRecipient = (records: MessageBulkInsertInterface[]): boolean => { | ||
| const re = /^[0-9+]+$/ | ||
| return records.some((record) => !record.recipient.match(re)) |
There was a problem hiding this comment.
re.test(record.recipient) should be faster. match returns an array of matched strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to allow users to upload csv with empty params as long as it is not in recipient column.
Closes #194
Solution
Features:
Improvements:
Validations:
+and numbers allowedvalidator.isEmailTests
SMS
Email
What tests should be run to confirm functionality?