-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade swagger-jsdoc from 4.0.0 to 5.0.1 #1075
[Snyk] Upgrade swagger-jsdoc from 4.0.0 to 5.0.1 #1075
Conversation
Snyk has created this PR to upgrade swagger-jsdoc from 4.0.0 to 4.3.2. See this package in npm: https://www.npmjs.com/package/swagger-jsdoc See this project in Snyk: https://app.snyk.io/org/open-government-products/project/0376d738-3c6b-42e2-92b1-64ef46f36225?utm_source=github&utm_medium=upgrade-pr
this breaks our current swagger docs. will need to look a little into what's wrong before upgrading |
It appears that v4.3.2 was a mistake in publishing and really should've been v5.0.0 instead (see ref). Hence, upgrade to the latest v5.x version which is v5.0.1 instead. Ref: https://github.com/Surnet/swagger-jsdoc/releases/tag/v4.3.2
Support for the 'path' prop has been removed in v5.0.0 (see ref). Migrate to the 'paths' prop instead, which is its direct replacement. Ref 1: https://github.com/Surnet/swagger-jsdoc/releases/tag/v5.0.0 Ref 2: https://github.com/Surnet/swagger-jsdoc/blob/v4.3.1/lib/helpers/specification.js#L55
The issue has been fixed. It happened because the deprecated 'path' property was removed in v4.3.2/v5.0.0 (they are equivalent). I've replaced it with the 'paths' prop. v4.3.2 also removed some other deprecated props, but none of them are currently being used in the codebase. I've verified that this works by placing my local docs and the staging docs side-by-side to compare. Both display the same API endpoints. |
* [Snyk] Upgrade swagger-jsdoc from 4.0.0 to 5.0.1 (#1075) * fix: upgrade swagger-jsdoc from 4.0.0 to 4.3.2 Snyk has created this PR to upgrade swagger-jsdoc from 4.0.0 to 4.3.2. See this package in npm: https://www.npmjs.com/package/swagger-jsdoc See this project in Snyk: https://app.snyk.io/org/open-government-products/project/0376d738-3c6b-42e2-92b1-64ef46f36225?utm_source=github&utm_medium=upgrade-pr * chore(backend): upgrade swagger-jsdoc to v5.0.1 It appears that v4.3.2 was a mistake in publishing and really should've been v5.0.0 instead (see ref). Hence, upgrade to the latest v5.x version which is v5.0.1 instead. Ref: https://github.com/Surnet/swagger-jsdoc/releases/tag/v4.3.2 * fix(swagger-jsdoc): use the 'paths' prop instead of 'path' Support for the 'path' prop has been removed in v5.0.0 (see ref). Migrate to the 'paths' prop instead, which is its direct replacement. Ref 1: https://github.com/Surnet/swagger-jsdoc/releases/tag/v5.0.0 Ref 2: https://github.com/Surnet/swagger-jsdoc/blob/v4.3.1/lib/helpers/specification.js#L55 Co-authored-by: Zhao Wei Liew <zhaoweiliew@gmail.com> * chore: upgrade libphonenumber from 1.9.9 to 1.9.16 * chore: upgrade aws-sdk to 2.884.0 * chore: upgrade source-map-support from 0.5.16 to 0.5.19 * chore: upgrade sequelize from 5.22.3 to 5.22.4 * chore: upgrade @google-cloud/storage from 5.8.1 to 5.8.2 * chore: upgrade winston-cloudwatch to 2.5.2 Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Zhao Wei Liew <zhaoweiliew@gmail.com>
Snyk has created this PR to upgrade swagger-jsdoc from 4.0.0 to 5.0.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Release notes
Package name: swagger-jsdoc
Unfortunately, the automated publishing script wrongly published this patch instead of v5 https://github.com/Surnet/swagger-jsdoc/releases/tag/v5.0.0
Please ignore this update and bump to major or do stay at 4.3.1 until updating your tags as mentioned in #220
bump version
It's now possible to include your
.coffee
files into the result swagger specification.Example:
add jest
refactor tests to match linting suggestions
refactor cli test
migrate test for openapi compatibility
migrate test for openapi compatibility
refactor test for example app v2
migrate helpers
reorganize addDataToSwaggerObject
move lib-specific test to the right place
rename
rename fixtures to files
migrate open api spec
remove unnecessary line
move v2 example files
update .editorconfig file
remove mocha
attempt to respect nvmrc
attempt to respect nvmrc
attempt to respect nvmrc
set node version
set 10
try a matrix instead
try snapshot update
update tests
update github workflow
make a test with patch version (#217)
update github workflow
@ openapi
instead of@ swagger
#200Upgrade dependencies to solve security vulnerabilities.
Node version 8 aka Carbon is no longer supported. Please refer to this information regarding release. Version 3 of swagger-jsdoc is still available at branch v3, but will not be maintained any more.
Please use Node version 10 aka Dubnium or higher.
Commit messages
Package name: swagger-jsdoc
Compare
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs