Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade swagger-jsdoc from 4.0.0 to 5.0.1 #1075

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Mar 22, 2021

Snyk has created this PR to upgrade swagger-jsdoc from 4.0.0 to 5.0.1.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 8 versions ahead of your current version.
  • The recommended version was released 5 months ago, on 2020-10-28.
Release notes
Package name: swagger-jsdoc
  • 4.3.2 - 2020-10-28

    ⚠️Patch containing breaking changes!!!⚠️

    Unfortunately, the automated publishing script wrongly published this patch instead of v5 https://github.com/Surnet/swagger-jsdoc/releases/tag/v5.0.0

    Please ignore this update and bump to major or do stay at 4.3.1 until updating your tags as mentioned in #220

  • 4.3.1 - 2020-10-22

    bump version

  • 4.3.0 - 2020-10-13

    It's now possible to include your .coffee files into the result swagger specification.

    Example:

    swagger-jsdoc.js -d example/v2/swaggerDef.js example/v2/route.coffee
  • 4.2.3 - 2020-10-08
    • add jest

    • refactor tests to match linting suggestions

    • refactor cli test

    • migrate test for openapi compatibility

    • migrate test for openapi compatibility

    • refactor test for example app v2

    • migrate helpers

    • reorganize addDataToSwaggerObject

    • move lib-specific test to the right place

    • rename

    • rename fixtures to files

    • migrate open api spec

    • remove unnecessary line

    • move v2 example files

    • update .editorconfig file

    • remove mocha

    • attempt to respect nvmrc

    • attempt to respect nvmrc

    • attempt to respect nvmrc

    • set node version

    • set 10

    • try a matrix instead

    • try snapshot update

    • update tests

    • update github workflow

  • 4.2.2 - 2020-10-08

    make a test with patch version (#217)

  • 4.2.1 - 2020-10-08

    update github workflow

  • 4.2.0 - 2020-09-25
    • It's now possible to annotate code with @ openapi instead of @ swagger #200
    • improved error messages for inputs #208
  • 4.1.0 - 2020-09-25

    Upgrade dependencies to solve security vulnerabilities.

  • 4.0.0 - 2020-03-22

    Node version 8 aka Carbon is no longer supported. Please refer to this information regarding release. Version 3 of swagger-jsdoc is still available at branch v3, but will not be maintained any more.

    Please use Node version 10 aka Dubnium or higher.

from swagger-jsdoc GitHub release notes
Commit messages
Package name: swagger-jsdoc

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@lamkeewei
Copy link
Contributor

this breaks our current swagger docs. will need to look a little into what's wrong before upgrading

@lamkeewei lamkeewei requested a review from zwliew March 31, 2021 05:01
zwliew added 2 commits March 31, 2021 15:32
It appears that v4.3.2 was a mistake in publishing and really should've
been v5.0.0 instead (see ref).

Hence, upgrade to the latest v5.x version which is v5.0.1 instead.

Ref: https://github.com/Surnet/swagger-jsdoc/releases/tag/v4.3.2
Support for the 'path' prop has been removed in v5.0.0 (see ref).
Migrate to the 'paths' prop instead, which is its direct replacement.

Ref 1: https://github.com/Surnet/swagger-jsdoc/releases/tag/v5.0.0
Ref 2: https://github.com/Surnet/swagger-jsdoc/blob/v4.3.1/lib/helpers/specification.js#L55
@zwliew
Copy link
Contributor

zwliew commented Mar 31, 2021

The issue has been fixed. It happened because the deprecated 'path' property was removed in v4.3.2/v5.0.0 (they are equivalent). I've replaced it with the 'paths' prop.

v4.3.2 also removed some other deprecated props, but none of them are currently being used in the codebase.

I've verified that this works by placing my local docs and the staging docs side-by-side to compare. Both display the same API endpoints.

@zwliew zwliew changed the title [Snyk] Upgrade swagger-jsdoc from 4.0.0 to 4.3.2 [Snyk] Upgrade swagger-jsdoc from 4.0.0 to 5.0.1 Mar 31, 2021
@lamkeewei lamkeewei changed the base branch from develop to upgrade-deps April 12, 2021 01:35
@lamkeewei lamkeewei merged commit 58ea8ab into upgrade-deps Apr 12, 2021
@lamkeewei lamkeewei deleted the snyk-upgrade-6d83ac7c6092d8b6c7cd0692cd6d07f3 branch April 12, 2021 01:35
lamkeewei added a commit that referenced this pull request Apr 14, 2021
* [Snyk] Upgrade swagger-jsdoc from 4.0.0 to 5.0.1 (#1075)

* fix: upgrade swagger-jsdoc from 4.0.0 to 4.3.2

Snyk has created this PR to upgrade swagger-jsdoc from 4.0.0 to 4.3.2.

See this package in npm:
https://www.npmjs.com/package/swagger-jsdoc

See this project in Snyk:
https://app.snyk.io/org/open-government-products/project/0376d738-3c6b-42e2-92b1-64ef46f36225?utm_source=github&utm_medium=upgrade-pr

* chore(backend): upgrade swagger-jsdoc to v5.0.1

It appears that v4.3.2 was a mistake in publishing and really should've
been v5.0.0 instead (see ref).

Hence, upgrade to the latest v5.x version which is v5.0.1 instead.

Ref: https://github.com/Surnet/swagger-jsdoc/releases/tag/v4.3.2

* fix(swagger-jsdoc): use the 'paths' prop instead of 'path'

Support for the 'path' prop has been removed in v5.0.0 (see ref).
Migrate to the 'paths' prop instead, which is its direct replacement.

Ref 1: https://github.com/Surnet/swagger-jsdoc/releases/tag/v5.0.0
Ref 2: https://github.com/Surnet/swagger-jsdoc/blob/v4.3.1/lib/helpers/specification.js#L55

Co-authored-by: Zhao Wei Liew <zhaoweiliew@gmail.com>

* chore: upgrade libphonenumber from 1.9.9 to 1.9.16

* chore: upgrade aws-sdk to 2.884.0

* chore: upgrade source-map-support from 0.5.16 to 0.5.19

* chore: upgrade sequelize from 5.22.3 to 5.22.4

* chore: upgrade @google-cloud/storage from 5.8.1 to 5.8.2

* chore: upgrade winston-cloudwatch to 2.5.2

Co-authored-by: Snyk bot <snyk-bot@snyk.io>
Co-authored-by: Zhao Wei Liew <zhaoweiliew@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants