-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul .gitignore structure #1081
Comments
OK, as a first step I will modify the current setup to make sure all files which are in the repo currently are not being ignored. My questions:
|
@bilderbuchi yeah the xcconfig should not be there. |
@arturoc , could I have a confirmation either way about paths.make? You explicitly added this to the .gitignore in 8dacae8, but never kicked it out of the repo. Was this an oversight, and should it be deleted? Or should it be in, but then why add it to the ignore list? |
paths.make should be there as an example on how to set it up but changes to it should be ignored cause everyone will have a different version in their computers so we don't want it to appear in the unstaged changes. it's kind of weird but it's the only solution i could come up with if. a El 28/03/2012, a las 13:54, Christoph Buchner escribió:
|
But currently (because it's already tracked) changes to it appear in git status, so I think this solution doesn't actually work at all. E.g. 580d608#diff-1 One way would be to do I think the best way to solve this is to rename it to |
yes that seems a great idea let it like it is by now and remove the gitignore if it's not working. i'll change it later but need the setup guide to be consistent with the repo. thanks! a El 28/03/2012, a las 14:09, Christoph Buchner escribió:
|
Will do! I'll put my solution into a separate issue (so we remember). |
yes please, even if you want to send a PR and i'll merge it as soon as i can fix the docs that would be great! thanks! El 28/03/2012, a las 14:13, Christoph Buchner escribió:
|
Done. See #1118. As I mentioned there, how do we deal with when the makefile does not find the customized paths.make? If you tell/code me that, I can do the PR. Let's continue discussion there. |
The gitignore structure needs an overhaul. It's become really confusing to read, rules are duplicated (that could be interesting to debug one day:P), and some things don't get ignored properly.
I plan to tackle this some time soon, but will wait for the project manager and whole repo to settle down a bit more. Work will probably happen in https://github.com/bilderbuchi/openFrameworks/tree/gitignore-fixes.
This issue is for the RFC from the core that I'll definitely have when figuring out what you really want/need ignored and what not.
The text was updated successfully, but these errors were encountered: