Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A collection of updates for the addons template. #14

Merged
merged 12 commits into from
Nov 2, 2016
Merged

A collection of updates for the addons template. #14

merged 12 commits into from
Nov 2, 2016

Conversation

bakercp
Copy link
Member

@bakercp bakercp commented May 20, 2014

See the commit log for more specifics.

  • Unit tests
  • Documentation
  • addons_config.mk
  • ofxaddons_thumbnail.png
  • Example names.
  • Updated README.
  • removed libsorder.make.

@bakercp
Copy link
Member Author

bakercp commented May 20, 2014

@bilderbuchi - I just merged the changes from @LeoColomb.

Sorry @LeoColomb I didn't see your existing PR in here.

@LeoColomb
Copy link
Member

@bakercp No problem.
Fixes #13

@bilderbuchi
Copy link
Member

I just had time for a quick once-over, but this looks good as far as I can see. Only thing, about that tests folder, will people know what to do with that if there's no docs, and we don't even have a testing process in place in OF itself? Still think it's a good idea, but maybe this needs a bit more detail?

@LeoColomb
Copy link
Member

Oh I just see you add a empty tests folder, and I'm personally against to add this, because:

  • as empty, it will not encourage to write tests
  • it will pollute a lot of "small" addons which will not have tests script
  • it will be less direct to see if a addon have tests

@bakercp
Copy link
Member Author

bakercp commented May 22, 2014

@LeoColomb @bilderbuchi Yes, I agree -- an empty tests folder with no documentation is counter productive. Before merging this I'll delete it. I added it because of a recent set of discussions around unit testing, but since that discussion isn't finished, a tests folder doesn't make sense for now. @LeoColomb - do you feel the same way about the docs folder? It seems that if everyone fills out a simple Doxygen configuration file, the ecosystem of oF documentation would be greatly improved ... as it sets up an expectation that code should be at least minimally documented :)

@LeoColomb
Copy link
Member

Well yes, I do. Furthermore, docs isn't the right name for a folder containing Doxygen configuration file, because as explained in GitHub Guides, docs folder is for documentation not settings. By recent experience for my studies with the NodeJS scripting, this kind of files HAVE to be on the root.

@bakercp
Copy link
Member Author

bakercp commented Nov 2, 2016

Ping?

@arturoc arturoc merged commit f57b24f into openframeworks:master Nov 2, 2016
@arturoc
Copy link
Member

arturoc commented Nov 2, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants