Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of this dirty hack (tag.replaceAll("(en:|fr:)", "")) for language management #852

Closed
Tracked by #4170
teolemon opened this issue Feb 21, 2018 · 8 comments

Comments

@teolemon
Copy link
Member

Getting rid of this dirty hack

String tagWithoutLocale = tag.replaceAll("(en:|fr:)", "").toUpperCase(Locale.getDefault());
We have many more locales, beyond en: and fr:

@iml-v
Copy link
Contributor

iml-v commented Feb 21, 2018

@teolemon i will correct this ,should i go ahead ?

@samagra14
Copy link
Contributor

I was just gonna open an issue for that 😅 . Thanks.

@teolemon
Copy link
Member Author

How would you both go about solving it ? That's a very good opportunity to delve into the language subtleties of the API :)

@iml-v
Copy link
Contributor

iml-v commented Feb 21, 2018

@samagra14 wanted to work on this issue before me ,so i will go with other issues at the same time @teolemon :)

@iml-v
Copy link
Contributor

iml-v commented Feb 21, 2018

@samagra14 confirm if you will work on this or should i work ?

@samagra14
Copy link
Contributor

I am working on this.

@Karljoones
Copy link
Member

@samagra14 are you still working on this?

@teolemon teolemon changed the title Getting rid of this dirty hack for language management Getting rid of this dirty hack (tag.replaceAll("(en:|fr:)", "")) for language management Aug 22, 2021
@VaiTon
Copy link
Member

VaiTon commented Jan 21, 2022

I think we can close this @teolemon.

@VaiTon VaiTon closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants