Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "Period after Opening" field for Open Beauty Facts #191

Open
Tracked by #4168 ...
teolemon opened this issue Nov 4, 2016 · 6 comments
Open
Tracked by #4168 ...

Add the "Period after Opening" field for Open Beauty Facts #191

teolemon opened this issue Nov 4, 2016 · 6 comments
Labels
easy fix Easily fixable issues, good for first timers Open Beauty Facts Issues relating to Open Beauty Facts Product page

Comments

@teolemon
Copy link
Member

teolemon commented Nov 4, 2016

This is to prepare support for Open Beauty Facts
http://en.wiki.openfoodfacts.org/API#Open_Beauty_Facts_experimental_and_specific_APIs

@teolemon teolemon modified the milestones: openbeautyfacts, Open Beauty Facts, Product Browsing Nov 19, 2016
@teolemon teolemon added the Open Beauty Facts Issues relating to Open Beauty Facts label Dec 21, 2016
@teolemon teolemon changed the title Add a hidden "Period after Opening" field Add a "Period after Opening" field for Open Beauty Facts Apr 5, 2017
@teolemon
Copy link
Member Author

teolemon commented Apr 5, 2017

We don't have the images exposed in the API yet. However, the URLs are simple to build:
https://static.openbeautyfacts.org/images/lang/en/periods_after_opening/12-months.90x90.svg

"periods_after_opening_tags":["en:12-months"]
"periods_after_opening":"12 M"
"periods_after_opening_debug_tags":[]
"periods_after_opening_hierarchy":["en:12-months"]

image

@teolemon teolemon changed the title Add a "Period after Opening" field for Open Beauty Facts Add the "Period after Opening" field for Open Beauty Facts May 21, 2017
@teolemon teolemon added easy fix Easily fixable issues, good for first timers feature labels May 21, 2017
@teolemon
Copy link
Member Author

We now have the taxonomy to translate the field:
https://static.openbeautyfacts.org/data/taxonomies/periods_after_opening.json

@balaji-ramavathu
Copy link
Contributor

Can I work on this issue?

@vanshikaarora
Copy link
Contributor

Hey @teolemon Is the Issue already solved?

I can see the field in the app. Or have I misunderstood the Issue?
IMG-20190517-WA0000

@teolemon
Copy link
Member Author

teolemon commented Jun 5, 2020

I think it works in edit mode, I need to check in display mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy fix Easily fixable issues, good for first timers Open Beauty Facts Issues relating to Open Beauty Facts Product page
Projects
None yet
Development

No branches or pull requests

3 participants