diff --git a/cms/static/sass/views/_index.scss b/cms/static/sass/views/_index.scss index ddb2ecce89f7..d571949cbaa0 100644 --- a/cms/static/sass/views/_index.scss +++ b/cms/static/sass/views/_index.scss @@ -71,8 +71,13 @@ body.index { color: $white; } + .wrapper-text-welcome, .logo { + display: inline-block; + } + .logo { font-weight: 600; + margin-left: ($baseline/2); } .tagline { diff --git a/cms/templates/howitworks.html b/cms/templates/howitworks.html index a791f5d1fadb..e3a92aa345fa 100644 --- a/cms/templates/howitworks.html +++ b/cms/templates/howitworks.html @@ -11,7 +11,7 @@
## "edX Studio" should not be translated -

${_('Welcome to')}

+

${_('Welcome to')}

${_("Studio helps manage your courses online, so you can focus on teaching them")}

diff --git a/lms/djangoapps/courseware/tests/test_views.py b/lms/djangoapps/courseware/tests/test_views.py index a5efe744a83a..879967419a7a 100644 --- a/lms/djangoapps/courseware/tests/test_views.py +++ b/lms/djangoapps/courseware/tests/test_views.py @@ -6,8 +6,10 @@ from django.test.utils import override_settings from django.contrib.auth.models import User from django.test.client import RequestFactory +from django.core.urlresolvers import reverse from student.models import CourseEnrollment +from student.tests.factories import AdminFactory from xmodule.modulestore.django import modulestore import courseware.views as views @@ -124,3 +126,27 @@ def verify_end_date(self, course_id, expected_end_text=None): self.assertContains(result, expected_end_text) else: self.assertNotContains(result, "Classes End") + + def test_submission_history_xss(self): + # log into a staff account + admin = AdminFactory() + + self.client.login(username=admin.username, password='test') + + # try it with an existing user and a malicious location + url = reverse('submission_history', kwargs={ + 'course_id': self.course_id, + 'student_username': 'dummy', + 'location': '' + }) + response = self.client.get(url) + self.assertFalse('', + 'location': 'dummy' + }) + response = self.client.get(url) + self.assertFalse('