-
Notifications
You must be signed in to change notification settings - Fork 186
Exception while masking/anonymizing SQL queries #431
Comments
@chloe-zh Could you have a look? Is all DESCRIBE and SHOW statements throwing exception? Curious why our IT didn't capture this. |
Both |
I see. It is because we "eat" the exception. sql/src/main/java/com/amazon/opendistroforelasticsearch/sql/utils/QueryDataAnonymizer.java Line 49 in 45fa29c
|
Probably we should follow the test case checklist here whenever adding new logic on main code path: https://github.com/opendistro-for-elasticsearch/sql/blob/master/docs/developing.rst#tips-for-testing |
@dai-chen yes, that was because the anonymizer is using the druid parser to build the temporary AST and reconstruct the anonymous query. Rather than throwing exceptions from druid parser (when anonymizing queries), we would prefer throw out exceptions from the syntax&semantic analyzer. |
Sounds good if we have this list of test cases for integration tests. |
This is currently a blocking issue when trying to use the ODBC driver through Excel. The same statement
|
After some more investigation, this might not be blocking Excel after all. Will update later whether this is the case. |
Both
SHOW
andDESCRIBE
are throwing exceptions.SQL Plugin: commit
bf4810dc26cc1782ab433bc97d63a6a0b326da11
elasticserach.log
The text was updated successfully, but these errors were encountered: