Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Improve Add Policy API by using transport action instead of timeout #42

Open
qreshi opened this issue Jul 24, 2019 · 0 comments
Open

Improve Add Policy API by using transport action instead of timeout #42

qreshi opened this issue Jul 24, 2019 · 0 comments
Labels
enhancement An improvement on the existing feature’s functionalities

Comments

@qreshi
Copy link
Contributor

qreshi commented Jul 24, 2019

The initial implementation of the Add Policy API had a concerning case where two requests to add policy could overwrite each other. The concern was brought up here.

As a temporary fix, a timeout of 30 seconds was added to the Add Policy API action. As a more permanent fix, a transport action should perform the logic of iterating through the cluster state and updating the indices' settings on the master node itself, preventing requests to add policy both returning 200 status and one overwriting the other.

@qreshi qreshi added the enhancement An improvement on the existing feature’s functionalities label Jul 24, 2019
@qreshi qreshi changed the title Improve Add Policy by using transport action instead of timeout Improve Add Policy API by using transport action instead of timeout Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement on the existing feature’s functionalities
Projects
None yet
Development

No branches or pull requests

1 participant