Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[BUG] PR with no license headers didn't fail checks #144

Open
dbbaughe opened this issue Feb 5, 2020 · 1 comment
Open

[BUG] PR with no license headers didn't fail checks #144

dbbaughe opened this issue Feb 5, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@dbbaughe
Copy link
Contributor

dbbaughe commented Feb 5, 2020

Describe the bug
This PR had some files with missing license headers. It should fail an automatic check instead of relying on human verification.

Expected behavior
Run ./gradlew build with a source file w/ no License Header and fail.
@dbbaughe dbbaughe added the bug Something isn't working label Feb 5, 2020
@dbbaughe
Copy link
Contributor Author

dbbaughe commented Apr 3, 2020

Skips when there are no java files which is why task isn't running
https://github.com/elastic/elasticsearch/blob/master/buildSrc/src/main/groovy/org/elasticsearch/gradle/precommit/LicenseHeadersTask.groovy#L71

@adityaj1107 adityaj1107 mentioned this issue Jun 3, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbbaughe