Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fe-angular quickstarter fails build with node_modules/rxjs/internal/types.d.ts(81,44): error TS1005: ';' #129

Closed
torstenhe opened this issue Feb 22, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@torstenhe
Copy link
Contributor

torstenhe commented Feb 22, 2019

Jenkins build / yarn fails with

node_modules/rxjs/internal/types.d.ts(81,44): error TS1005: ';' expected. node_modules/rxjs/internal/types.d.ts(81,74): error TS1005: ';' expected. node_modules/rxjs/internal/types.d.ts(81,77): error TS1109: Expression expected. 

there is already a fix available
see ReactiveX/rxjs#4512

@torstenhe torstenhe added the bug Something isn't working label Feb 22, 2019
@clemensutschig
Copy link
Member

The fix is a package.json change to typescript 2.8

@cschweikert
Copy link
Member

There is not much we can do about this, since the quickstarter for Angular creates the content of a new repository by running ng new. This will also create a package.json file with the problematic version of typescript. As possible solution I would recommend an update of the Angular version on the quickstarter.
Possible workarounds for now:

  • update typescript manually to version 2.8
  • run ng update

@clemensutschig
Copy link
Member

Sed replace - done ;-)

@cschweikert
Copy link
Member

fixed in master and 1.0.x

@cschweikert
Copy link
Member

Oh, actually there is no typescript version 2.8.0 :-( Why? Anyways.
I reopen the ticket and will change to 2.8.1, which indeed is existing.

@cschweikert
Copy link
Member

updated to 2.8.1 on master and 1.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants