Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent default DSCs for different methods of creation #428

Closed
strangiato opened this issue Aug 8, 2023 · 1 comment · Fixed by #465
Closed

Inconsistent default DSCs for different methods of creation #428

strangiato opened this issue Aug 8, 2023 · 1 comment · Fixed by #465
Labels
bug Something isn't working

Comments

@strangiato
Copy link
Contributor

strangiato commented Aug 8, 2023

Describe the bug
When using different methods for creating the DSC, the default YAML object changes what the user is presented.

To Reproduce
When using the Create DataScienceCluster button on the DSC tab or the Create instance button on the details tab

image

The following object is auto populated:

kind: DataScienceCluster
apiVersion: datasciencecluster.opendatahub.io/v1alpha1
metadata:
  labels:
    app.kubernetes.io/created-by: opendatahub-operator
    app.kubernetes.io/instance: default
    app.kubernetes.io/managed-by: kustomize
    app.kubernetes.io/name: datasciencecluster
    app.kubernetes.io/part-of: opendatahub-operator
  name: default
spec:
  components:
    dashboard:
      enabled: false
    datasciencepipelines:
      enabled: false
    distributedworkloads:
      enabled: false
    kserve:
      enabled: false
    modelmeshserving:
      enabled: false
    workbenches:
      enabled: false

When using the Create DataScienceCluster button on the DataSciecneCluster required section of the details tab

image

The following object is auto populated:

kind: DataScienceCluster
apiVersion: datasciencecluster.opendatahub.io/v1alpha1
metadata:
  name: default
spec: {}

Expected behavior
Using both options I would expect the object to auto-populate to something like this:

kind: DataScienceCluster
apiVersion: datasciencecluster.opendatahub.io/v1alpha1
metadata:
  name: default
spec:
  components:
    dashboard:
      enabled: true
    datasciencepipelines:
      enabled: true
    distributedworkloads:
      enabled: true
    kserve:
      enabled: true
    modelmeshserving:
      enabled: true
    workbenches:
      enabled: true

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
In previous discussion we have talked about the idea that all of the components should be enabled as true by default, and allow the users to turn off things that they don't want. By enabling everything by default we are giving new users a default configuration that will allow them to explore all of the components and they can choose to remove components as needed at a later time.

@strangiato strangiato added the bug Something isn't working label Aug 8, 2023
@zdtsw
Copy link
Member

zdtsw commented Aug 21, 2023

related to #432

both issues request change from default "false" to "true" when create new DSC instance.

As for the part When using the Create DataScienceCluster button on the DataSciecneCluster required
the empty spec: {} is auto set to what is defined as default in the code base
which is the same as (as the current implementation "fasle")

spec:
  components:
    dashboard:
      enabled: false
    datasciencepipelines:
      enabled: false
    distributedworkloads:
      enabled: false
    kserve:
      enabled: fasle
    modelmeshserving:
      enabled: false
    workbenches:
      enabled: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants