Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSG]: Create generic breadcrumb component that works with DSG #560

Closed
dlabaj opened this issue Sep 15, 2022 · 2 comments
Closed

[DSG]: Create generic breadcrumb component that works with DSG #560

dlabaj opened this issue Sep 15, 2022 · 2 comments
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible

Comments

@dlabaj
Copy link
Contributor

dlabaj commented Sep 15, 2022

Feature description

Create a generic component that can be used in App.tsx to show the current location as a breadcrumb. Ideally this component will handle updating itself without any input from the developer. The component should use the patternfly breadcrumb.

Describe alternatives you've considered

Consider just using the patternfly bread crumb as is, however it would be difficult to update the breadcrumb based on the current architecture.

Anything else?

Recommend pulling in i18n to translate the routes correctly.
@dlabaj dlabaj added kind/enhancement New functionality request (existing augments or new additions) priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) labels Sep 15, 2022
@dlabaj dlabaj self-assigned this Sep 15, 2022
@andrewballantyne andrewballantyne added this to the Initial DSG Work milestone Sep 15, 2022
@andrewballantyne andrewballantyne moved this from Backlog to In progress in ODH Dashboard Planning Sep 15, 2022
@andrewballantyne andrewballantyne mentioned this issue Sep 15, 2022
Closed
@andrewballantyne andrewballantyne changed the title [Feature Request]: Create generic breadcrumb component that works with DSG [DSG]: Create generic breadcrumb component that works with DSG Sep 15, 2022
@DaoDaoNoCode DaoDaoNoCode mentioned this issue Sep 20, 2022
Merged
3 tasks
@dlabaj dlabaj mentioned this issue Sep 27, 2022
Closed
@andrewballantyne andrewballantyne moved this from In progress to In review in ODH Dashboard Planning Sep 28, 2022
@andrewballantyne andrewballantyne linked a pull request Sep 28, 2022 that will close this issue
Added code for dynamic bread crumb #607
Closed
@andrewballantyne andrewballantyne added infrastructure Anything non feature/* related that improves general working of the Dashboard priority/normal An issue with the product; fix when possible and removed priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) labels Oct 18, 2022
@andrewballantyne andrewballantyne removed this from the DSG Work milestone Oct 18, 2022
@andrewballantyne
Copy link
Member

Pulled from DSG as it was not viable... we will need to go back through and add breadcrumbs manually.

@andrewballantyne andrewballantyne moved this from In review to To do in ODH Dashboard Planning Oct 26, 2022
@andrewballantyne andrewballantyne moved this from To do to Backlog in ODH Dashboard Planning Nov 30, 2022
@andrewballantyne
Copy link
Member

Going to close this issue. Until we can cover our bases with UX and how this will have value over the growth of the Dashboard.

@github-project-automation github-project-automation bot moved this from Backlog to Done in ODH Dashboard Planning Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added code for dynamic bread crumb dlabaj/odh-dashboard
2 participants
@dlabaj @andrewballantyne