Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async read need #2070

Closed
wuhongsong opened this issue Nov 14, 2022 · 4 comments
Closed

Async read need #2070

wuhongsong opened this issue Nov 14, 2022 · 4 comments
Assignees
@Ziy1-Tan
Labels
Developer Activities enhancement improve feature good first issue Good for newcomers

Comments

@wuhongsong
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

in function of ReadFromS3, the default is sync read

Describe the solution you'd like (描述你期望的解决方法)

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)
@wuhongsong wuhongsong added the enhancement improve feature label Nov 14, 2022
@wuhongsong wuhongsong mentioned this issue Nov 14, 2022
Open
@YLShiJustFly
Copy link

Dear Song, Let me have a try.

@wuhongsong wuhongsong assigned YLShiJustFly and unassigned cw123 Nov 15, 2022
@zhanghuidinah zhanghuidinah mentioned this issue Nov 16, 2022
Closed
2 tasks
@cw123 cw123 mentioned this issue Nov 28, 2022
Closed
2 tasks
@wuhongsong
Copy link
Contributor Author

@YLShiJustFly

@caoxianfei1 caoxianfei1 added the good first issue Good for newcomers label Mar 1, 2023
@Ziy1-Tan
Copy link
Contributor

Ziy1-Tan commented Mar 1, 2023

It seem that ReadFromS3 is not existed, do you mind to update desc?

@wuhongsong
Copy link
Contributor Author

It seem that ReadFromS3 is not existed, do you mind to update desc?

yep，FileCacheManager::ReadKVRequest has replaced， so maybe we can use asynchronies io in it

@Ziy1-Tan Ziy1-Tan mentioned this issue Apr 24, 2023
Merged
2 tasks
@ilixiaocui ilixiaocui mentioned this issue Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ziy1-Tan Ziy1-Tan

Labels
Developer Activities enhancement improve feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cw123 @wuhongsong @zhanghuidinah @Ziy1-Tan @caoxianfei1 @YLShiJustFly