Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming Config.UidMappings and GidMappings to UIDMappings and GIDMappings #3936

Closed
rata opened this issue Jul 12, 2023 · 0 comments · Fixed by #3939
Closed

Consider renaming Config.UidMappings and GidMappings to UIDMappings and GIDMappings #3936

rata opened this issue Jul 12, 2023 · 0 comments · Fixed by #3939

Comments

@rata
Copy link
Member

rata commented Jul 12, 2023 •
edited
Loading

Description

As noted by @thaJeztah here

Not for this PR (as it's existing code), but we should look at properly naming these fields as well (UIDMappings , GIDMappings)

We should probably rename the config fields to have capitalized UID/GID.

Fiurthermore, IIRC, when I added the UIDMappings and GIDMappings for mounts in that PR, I tried to name them the same way it is in the config (UidMappings and GidMappings) but the linter complained about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming *Mappings fields and use int* for mountEntry.fd eiffel-fl/runc
1 participant
@rata