Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Relocate wrapper tests #2424

Closed
1 task done
RedTachyon opened this issue Sep 27, 2021 · 2 comments
Closed
1 task done

[Proposal] Relocate wrapper tests #2424

RedTachyon opened this issue Sep 27, 2021 · 2 comments

Comments

@RedTachyon
Copy link
Contributor

Proposal

This is basically my inner pedant speaking. The tests for wrappers are all sitting in gym/wrappers, when there's a perfectly fine (and empty) gym/wrappers/tests directory sitting there, so they should be moved there.

Motivation

Despaghettification of the file/directory structure

Pitch

Put wrappers tests into wrappers/tests

Alternatives

Live with it.

Additional context

The one case where I see this being breaking in any way if someone imports the tests from gym with hardcoded paths and uses them in downstream code, which feels cursed and I really hope nobody does that.

Also in theory it's possible that one of the tests is written in a way that requires it to be in gym/wrappers (e.g. with relative imports), but from a quick glance I don't see anything like that, and if there were, it'd be worth fixing (and would trivially appear when running tests)

I can make a quick PR later today and pray that nothing breaks.

Checklist

  • I have checked that there is no similar issue in the repo (required)
@jkterry1
Copy link
Collaborator

There's also a tests/gym/wrappers. My preference would to move all tests into the format of tests/xxx, e.g. tests/wrappers, tests/envs, etc.

@jkterry1
Copy link
Collaborator

Closing in favor of PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants