You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is basically my inner pedant speaking. The tests for wrappers are all sitting in gym/wrappers, when there's a perfectly fine (and empty) gym/wrappers/tests directory sitting there, so they should be moved there.
Motivation
Despaghettification of the file/directory structure
Pitch
Put wrappers tests into wrappers/tests
Alternatives
Live with it.
Additional context
The one case where I see this being breaking in any way if someone imports the tests from gym with hardcoded paths and uses them in downstream code, which feels cursed and I really hope nobody does that.
Also in theory it's possible that one of the tests is written in a way that requires it to be in gym/wrappers (e.g. with relative imports), but from a quick glance I don't see anything like that, and if there were, it'd be worth fixing (and would trivially appear when running tests)
I can make a quick PR later today and pray that nothing breaks.
Checklist
I have checked that there is no similar issue in the repo (required)
The text was updated successfully, but these errors were encountered:
Proposal
This is basically my inner pedant speaking. The tests for wrappers are all sitting in
gym/wrappers
, when there's a perfectly fine (and empty)gym/wrappers/tests
directory sitting there, so they should be moved there.Motivation
Despaghettification of the file/directory structure
Pitch
Put wrappers tests into
wrappers/tests
Alternatives
Live with it.
Additional context
The one case where I see this being breaking in any way if someone imports the tests from gym with hardcoded paths and uses them in downstream code, which feels cursed and I really hope nobody does that.
Also in theory it's possible that one of the tests is written in a way that requires it to be in
gym/wrappers
(e.g. with relative imports), but from a quick glance I don't see anything like that, and if there were, it'd be worth fixing (and would trivially appear when running tests)I can make a quick PR later today and pray that nothing breaks.
Checklist
The text was updated successfully, but these errors were encountered: