Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset() calls from __init__ ? #2242

Closed
srvanrell opened this issue Jun 16, 2021 · 2 comments · Fixed by #2394
Closed

reset() calls from __init__ ? #2242

srvanrell opened this issue Jun 16, 2021 · 2 comments · Fixed by #2394
Labels
PR Needed

Comments

@srvanrell
Copy link

Some envs in classic_control call reset() in their __init__.py and others don't.
Is there any rule about it?

Do

gym/gym/envs/classic_control/continuous_mountain_car.py

Line 64 in ee5ee3a

self.reset()

Don't

gym/gym/envs/classic_control/mountain_car.py

Line 84 in ee5ee3a

self.seed()

gym/gym/envs/classic_control/cartpole.py

Line 94 in ee5ee3a

self.state = None

@jkterry1
Copy link
Collaborator

It should not be called in init if done properly.

@ahmedo42 ahmedo42 mentioned this issue Sep 5, 2021
Merged
@jkterry1
Copy link
Collaborator

Closing in favor of PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed calls to reset from init ahmedo42/gym
2 participants
@srvanrell @jkterry1