Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear error message for unsupported file format #1471

Closed
eschnett opened this issue Jul 3, 2023 · 1 comment · Fixed by #1473
Closed

Unclear error message for unsupported file format #1471

eschnett opened this issue Jul 3, 2023 · 1 comment · Fixed by #1473
Assignees
@franzpoeschel
Labels
cosmetic feature request
Milestone
0.15.2

Comments

@eschnett
Copy link
Contributor

eschnett commented Jul 3, 2023

I tried to write a JSON-formatted file with openPMD_api 0.15.1. I received the error message Unknown file format! Did you specify a file ending?.

It would be nice if the error message included the file name and the suffix that openPMD doesn't understand.
@franzpoeschel franzpoeschel self-assigned this Jul 6, 2023
This was referenced Jul 7, 2023
Merged
Merged
@ax3l ax3l added this to the 0.15.2 milestone Jul 18, 2023
@ax3l
Copy link
Member

ax3l commented Jul 18, 2023

Thank you for the report and @franzpoeschel for the fix.

This will be part of the 0.15.2 release.

@ax3l ax3l added the cosmetic label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franzpoeschel franzpoeschel

Labels
cosmetic feature request
Projects
None yet
Milestone
0.15.2
Development

Successfully merging a pull request may close this issue.

Better handling for file extensions franzpoeschel/openPMD-api
3 participants
@eschnett @ax3l @franzpoeschel