Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make container.labels and k8s.pod.labels singular #606

Closed
ChrsMark opened this issue Dec 13, 2023 · 0 comments · Fixed by #625
Closed

Make container.labels and k8s.pod.labels singular #606

ChrsMark opened this issue Dec 13, 2023 · 0 comments · Fixed by #625
Assignees
@jsuereth

Comments

@ChrsMark
Copy link
Member

At #573 (comment) it was discussed that annotations and labels should not be pluralized.

#573 is changed accordingly. Once it is merged we will need follow up PRs to tune k8s.pod.labels and container.labels as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depluralize labels for pod and container resources ChrsMark/semantic-conventions
2 participants
@jsuereth @ChrsMark