-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTel Demo] - Quote Service Metrics #2669
Comments
thanks for raising this @julianocosta89 ! |
@open-telemetry/demo-approvers @open-telemetry/php-approvers is this still relevant? |
Yes, we need to update this section: https://opentelemetry.io/docs/demo/services/quote/#metrics I can take care of this |
thanks @julianocosta89 |
if this issue is still active, please assign this issue to me, thanks |
hey @kennykguo, Please note that we are not assigning issues, as per our contribution guidelines, if you are interested to work on this issue let us know, and we keep track and wait for a PR from you. I recommend that you pick 1 or 2 issues you fill confident to provide a PR for within ~2 weeks. |
@kennykguo feel free to take it, I've actually forgot to update it. I'm not sure how we could add that in the docs, but I'm open to suggestions. |
@brettmc do you think we have something to add to the Metrics section of the PHP service in the docs? Otherwise I'll just close this issue |
Yes, I've just submitted a PR to add some manual metrics to quote service (there are some auto-generated ones there already), then I'll update the Metrics and Logs sections of the docs. |
This OTel Demo PR added metrics to the PHP service.
We need to add the process to the docs.
The text was updated successfully, but these errors were encountered: